take-five / activerecord-hierarchical_query

Simple DSL for creating recursive queries with ActiveRecord
MIT License
119 stars 24 forks source link

Inv2.0/changes for laq #11

Closed nickfarina closed 8 years ago

nickfarina commented 8 years ago

This provides functionality to specify the UNION type. The default was UNION ALL, but we found that we would need a UNION DISTINCT some times. Right now those are the only two supported.

There is an Arel monkey-patch included in this PR, though I also went ahead created a PR for the Arel core project to implement these changes in there, which can be found here: https://github.com/rails/arel/pull/442

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 38799bc7eac4e73f08157796dd005124d14fae43 on blueapron:inv2.0/changes_for_laq into 5ca6a8de96dc13a325c1bdf5249352d88407c86f on take-five:master.

take-five commented 8 years ago

I'm gonna merge this PR to separate branch and fix Travis errors, if you don't mind