Makes the gem compatible with Rails 5

take-five / activerecord-hierarchical_query

Simple DSL for creating recursive queries with ActiveRecord

MIT License

119 stars 24 forks source link

Makes the gem compatible with Rails 5 #18

Closed walski closed 7 years ago

walski commented 7 years ago

Fixes #13

I must admit I have not the slightest clue about Arel and AR internals but the specs pass again and it seems to work :)

Happy to apply more changes as you find necessary @take-five

coveralls commented 7 years ago

Changes Unknown when pulling 8d6650e9b4a4e1868925708d00aca90a8697eb4c on walski:rails5Yeah into on take-five:master.

take-five commented 7 years ago

Hi @walski Thanks for the PR, I don't really have time to work on this project right now. Unfortunately all the existing specs for Rails 3.x and 4.x have failed, but I think it'll be better to have version for Rails 5 in a separate branch and get rid of all the nasty hacks that keep the gem compatible with older Rails.

take-five commented 7 years ago

Could you change your PR destination to rails-5 branch instead of master?

coveralls commented 7 years ago

Changes Unknown when pulling c0f4983d1b82ec7483b5dcd4282d7ed98d47f001 on walski:rails5Yeah into on take-five:rails-5.

coveralls commented 7 years ago

Changes Unknown when pulling dad279f7a619643e5f2d90d75f7315a0d0662dd4 on walski:rails5Yeah into on take-five:rails-5.

walski commented 7 years ago

There we go :)

take-five commented 7 years ago

Thanks a lot!

take-five commented 7 years ago

Check out version 1.0.0 from rubygems.org :)