search

take-five / activerecord-hierarchical_query

Simple DSL for creating recursive queries with ActiveRecord
MIT License
119 stars 24 forks source link

Rails 6 #27

Closed mkamensky closed 4 years ago

mkamensky commented 5 years ago

Is there an issue supporting it? Thanks

zachaysan commented 5 years ago

There are some failing tests, yeah. From my vantage point it looks like ActiveRecord has some poorly generated SQL after the latest refactor, so I'm inclined to wait it out and hope it fixes itself. But if you'd like to try your own hand at it, it's a pretty easy repo to get the tests running in, though you do need sudo in order to create the test db.

zachaysan commented 4 years ago

@mkamensky I think I have a fix ready here. I'm going cut a gem. Let me know if there are problems in your test suite.

zachaysan commented 4 years ago

Ok latest Gem has a fix for Rails 6 support, let me know if there are any other issues.

mkamensky commented 4 years ago

Thank you!

mkamensky commented 4 years ago

Now 6.0.1 is here...

zachaysan commented 4 years ago

What's the issue @mkamensky ?

anfinil commented 4 years ago

https://github.com/take-five/activerecord-hierarchical_query/pull/28 fixes it

mkamensky commented 4 years ago

Thanks, for the issue was simply that rails 6.0.1 is incompatible with the latest version, bundle was pulling an old one.

zachaysan commented 4 years ago

Ah, gotcha. Thanks for the PR @anfinil I've cut the new gem let me know if there are any problems.