search

take-five / activerecord-hierarchical_query

Simple DSL for creating recursive queries with ActiveRecord
MIT License
119 stars 24 forks source link

PG 1.2.x Support #29

Closed xtagon closed 4 years ago

xtagon commented 4 years ago

Hi,

I'd like to start using PG 1.2, and found this incompatibility:

Bundler could not find compatible versions for gem "pg":
  In Gemfile:
    pg (~> 1.2)

    activerecord-hierarchical_query (= 1.2.2) was resolved to 1.2.2, which depends on
      pg (< 1.2, >= 0.21)

Could activerecord-hierarchical_query be updated to support pg 1.2? I'm happy to help if needed, but I thought I'd bring it up in an issue first.

Thanks, and happy new year!

zachaysan commented 4 years ago

I'm just about to go to bed but I'll run the test suite early tomorrow. Usually this type of upgrade is easy. Thanks for creating the issue!

zachaysan commented 4 years ago

And of course! Happy New Year to you too!

zachaysan commented 4 years ago

Ok I pushed the new gem. The tests pass with pg 1.2 but I didn't get a chance to test the new gem in an actual rails project so if you run into issues please let me know. Have a great day and thanks for opening the issue!

xtagon commented 4 years ago

Thanks, I'll try it!