take-five / activerecord-hierarchical_query

Simple DSL for creating recursive queries with ActiveRecord
MIT License
119 stars 24 forks source link

Rails 6.1 Compatability #32

Closed walski closed 3 years ago

walski commented 3 years ago

This allows working with Rails 6.1 RC1.

walski commented 3 years ago

We're using this in production, now.

shellixyz commented 3 years ago

I can confirm this PR is working fine for me with Rails 6.1. Thanks @walski

sposin commented 3 years ago

Is there a particular reason this hasn't been merged?

travisofthenorth commented 3 years ago

@zachaysan you mind taking a look at this? Blocking 6.1 upgrade for us.

zachaysan commented 3 years ago

@travisofthenorth, @walski and everyone else: I'm very sorry, I was hospitalized and in otherwise poor health for months and this slipped. I'll merge and cut a gem for this now. Thank you very much for bringing it to my attention.

zachaysan commented 3 years ago

@travisofthenorth I've pushed the gem to rubygems, let me know if you have any trouble.

https://rubygems.org/gems/activerecord-hierarchical_query/versions/1.3.0

travisofthenorth commented 3 years ago

@zachaysan no worries. Thank you so much for the quick turnaround!

zachaysan commented 3 years ago

@travisofthenorth it's the least I could do.

I should investigate getting another maintainer in the event that this happens again, as my medical condition, while fine for now, could reappear. If you or @walski have any interest let me know.