search

takecian / SwiftRater

A utility that reminds your iPhone app's users to review the app written in pure Swift.
MIT License
356 stars 42 forks source link

Pops up everytime #19

Closed HelloDev18 closed 5 years ago

HelloDev18 commented 5 years ago

Hi, the dialog pops up from the first launch even if debug is false and in real device. Swift 4. iOS: 11.3. XCode 10.1 My Settings: SwiftRater.daysUntilPrompt = 3 SwiftRater.usesUntilPrompt = 1 SwiftRater.significantUsesUntilPrompt = 2 SwiftRater.daysBeforeReminding = 2

takecian commented 5 years ago

Hello, which version are you using? What api did you call for showing popup?

HelloDev18 commented 5 years ago

thanks for the quick reply, I use the latest version of your library SwiftRater.check()

takecian commented 5 years ago

Ah, I guess this is because you have set usesUntilPrompt 1.

Shows review request if users launch more than usesUntilPrompt times.

I documented above about usesUntilPrompt, but I checked code now this document is wrong,

Currently my library works "Shows review request if users launch more than equal usesUntilPrompt times." Could you try setting usesUntilPrompt is 2?

Anyway I will fix code to follow document.

takecian commented 5 years ago

I updated, 1.3.1. This works according to document,

Shows review request if users launch more than usesUntilPrompt times.

takecian commented 5 years ago

If you have question more, please reopen.