takecian / SwiftRater

A utility that reminds your iPhone app's users to review the app written in pure Swift.
MIT License
356 stars 42 forks source link

SwiftRater.incrementSignificantUsageCount() not triggering rating prompt #26

Open mozltovcoktail opened 5 years ago

mozltovcoktail commented 5 years ago

Hello, and thanks for the library! Everything works great in debug mode, but I can't seem to get the rating prompt to appear when using SwiftRater.incrementSignificantUsageCount(). I've used it to try to trigger a rating prompt after the third time a uses a tap gesture in my interface, but no prompt is appearing while testing. Any ideas why?

    SwiftRater.daysUntilPrompt = 3
    SwiftRater.usesUntilPrompt = 3
    SwiftRater.significantUsesUntilPrompt = 3
    SwiftRater.daysBeforeReminding = 2
    SwiftRater.showLaterButton = true
    // Set to false before submitting to App Store!!!!
    SwiftRater.debugMode = false
    SwiftRater.appLaunched()

    return true
    }
takecian commented 5 years ago

I'd like to know reproduction steps. If you have already show popup(e.g. after trying debug mode), it won't show popup until app version changed.

mozltovcoktail commented 5 years ago

Hi Takeshi,

It may very well be because I didn't increment the build number before trying again. I've submitted my app for App Store review, but will check this out tonight on a new dev version and see if I can get things working. Thank you VERY much for the prompt response.

On Thu, May 30, 2019 at 10:53 PM Takeshi Fujiki notifications@github.com wrote:

I'd like to know reproduction steps. If you have already show popup(e.g. after trying debug mode), it won't show popup until app version changed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/takecian/SwiftRater/issues/26?email_source=notifications&email_token=AAJP6J5NPOOTV2EZCKWENXTPYCHJTA5CNFSM4HRPWQZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUBYKQ#issuecomment-497556522, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJP6JYC5QGSRJPXT2BI6C3PYCHJTANCNFSM4HRPWQZA .

mozltovcoktail commented 5 years ago

Ok, I changed both my version number and my build number and installed it fresh on my phone. I set the significantUsesUntilPrompt in the AppDelegate.swift to 3, then did the action where I have SwiftRater.incrementSignificantUsageCount() placed three times, but no rating prompt appears. I put a little print statement after the action as well to make sure it's doing what I think it's doing, and that worked, but still no ratings prompt. Any ideas?

On Fri, May 31, 2019 at 9:27 AM Aaron Price aaronmorrisprice@gmail.com wrote:

Hi Takeshi,

It may very well be because I didn't increment the build number before trying again. I've submitted my app for App Store review, but will check this out tonight on a new dev version and see if I can get things working. Thank you VERY much for the prompt response.

Best, Aaron

On Thu, May 30, 2019 at 10:53 PM Takeshi Fujiki notifications@github.com wrote:

I'd like to know reproduction steps. If you have already show popup(e.g. after trying debug mode), it won't show popup until app version changed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

takecian commented 5 years ago

@mozltovcoktail sorry for late reply. Did it work well? If not, i'd like to know more details. Do you call SwiftRater.check() in viewcontroller?

mozltovcoktail commented 5 years ago

Here's what I have in viewcontroller:

override func viewDidAppear(_ animated: Bool) { super.viewDidAppear(animated) // Check to see if SwiftRater conditions are met SwiftRater.check(host: self) }