search

takecian / SwiftRater

A utility that reminds your iPhone app's users to review the app written in pure Swift.
MIT License
356 stars 42 forks source link

Add useStoreKitIfAvailable switch #3

Closed hyouuu closed 7 years ago

hyouuu commented 7 years ago

So app can choose whether they want to use StoreKit or not. BTW currently the storeKit is not submittable when I tried it.

takecian commented 7 years ago

@hyouuu , thank you for sending PR. BTW I think StoreKit is available for submitting app to AppStore. Did you get error when submitting apps including StoreKit?

hyouuu commented 7 years ago

I couldn't try it in production as it's too risky, but either way giving people a choice is better than none?

takecian commented 7 years ago

I'm not sure why developers want to avoid using StoreKit, why do you think using StoreKit is risky?

hyouuu commented 7 years ago

Because different UIs are arguably better or worse; I'm not saying using StoreKit is risky, but that in debug mode it doesn't work, and I can't put it in App Store version to try out whether it works in production

hyouuu commented 7 years ago

Thanks!

takecian commented 7 years ago

I've released with your PR as 0.1.5. Thank you!