Add Json Web Token Support

takeshixx / deen

Generic data DEcoding/ENcoding application built with PyQt5.

Apache License 2.0

46 stars 7 forks source link

Add Json Web Token Support #19

Closed SvenTo closed 5 years ago

SvenTo commented 7 years ago

Please add support for Json Web Token: https://pyjwt.readthedocs.io/en/latest/

pcrossy commented 6 years ago

maybe add "pip3 install pyjwt" to the installation guide, otherwise dependency is missing.

takeshixx commented 6 years ago

pyjwt is part of the requirements.txt and should be installed like this:

pip install -r requirements.txt

Added an installation hint in 8b5285f32d92727016c9f0ac621ddbd631662939, currently only in the develop branch. Will be moved to master with next minor release.

murx- commented 5 years ago

While pyjwt is part of the dependencies the actual implementation ( https://github.com/takeshixx/deen/blob/2d14861208c4c4a49aa1b74c7e1a85b68e150e3f/deen/plugins/codecs/jwt.py#L12 ) is using jose which is missing in the requirements.txt.

takeshixx commented 5 years ago

Updated dependencies in a6e5122c4c5266511d051dffb9afaf729309c5b8 and added an extra hint for optional dependencies that might have to be installed via package managers. Also splitted requirements for Python 2 and 3 because PyQt is only installable via pip on Python >3.5.

takeshixx commented 5 years ago

v2.0.0b1 implements JWT, but there are limitations due to bugs in the used JWT module:

Shared secrets that just contain numbers do not work.
Shared keys that include public keys do not work. I've forked the repository and fixed these two issues. But there might be more bugs. If these features are required, the fork should be used until the bugs are fixed in upstream.