search

takezoe / gitbucket-maven-repository-plugin

A GitBucket plugin that provides Maven repository hosting on GitBucket
14 stars 5 forks source link

Slash behind a file names too. #12

Closed aadrian closed 3 years ago

aadrian commented 5 years ago

The current version - https://plugins.gitbucket-community.org/releases/gitbucket-maven-repository-plugin/gitbucket-maven-repository-plugin-gitbucket_4.30.1-1.4.0.jar renders slashes behind file names too, not just directories, so it's very confusing what is a file name and what's a directory.

Thank you.

ziggystar commented 5 years ago

In addition it results in the file name being empty when downloading via browser. Apparently IE has a "bug", and there it works.

GabrieleFrau commented 3 years ago

This might be the cause https://github.com/takezoe/gitbucket-maven-repository-plugin/blob/f817f7130a3482fe9dfedaf59fd39ec8070c2d85/src/main/twirl/gitbucket/mavenrepository/files.scala.html#L46-L50

takezoe commented 3 years ago

Oh, that should be fixed!