search

takezoe / solr-scala-client

Solr Client for Scala
Apache License 2.0
91 stars 43 forks source link

Add CloudSolr support #45

Closed katameru closed 6 years ago

katameru commented 6 years ago

This pull request adds factory methods that create CloudSolrClient builders, and adds the ability to specify a non-default collection when building a query.

takezoe commented 6 years ago

Thanks! Is it possible to add CloudSolr support to the async client as well? https://github.com/takezoe/solr-scala-client/tree/master/src/main/scala/com/github/takezoe/solr/scala/async

katameru commented 6 years ago

Not as easily. CloudSolrClient coordinates with zookeeper and load balances requests, so if we wanted to use AsyncHttpClient we would have to re-implement/copy a lot of logic.

The alternative is to have an AsyncCloudSolrClient which just wraps calls to CloudSolrClient in Futures.

takezoe commented 6 years ago

OK, I will merge this request and consider support in async client after that.