search

taki0112 / UGATIT

Official Tensorflow implementation of U-GAT-IT: Unsupervised Generative Attentional Networks with Adaptive Layer-Instance Normalization for Image-to-Image Translation (ICLR 2020)
MIT License
6.17k stars 1.04k forks source link

Update utils.py #28

Open ZhanruiLiang opened 5 years ago

ZhanruiLiang commented 5 years ago

The existing one won't work.

1mpossibleHacker commented 5 years ago

I agree

taki0112 commented 5 years ago

I've checked, but it works Why did you add the comma?

ZhanruiLiang commented 5 years ago

I should've said "won't work as expected". ('true') is the same as 'true' but here I believe the intent here is to have a tuple which should be ('true',). Otherwise you've had used the parens. The current way somehow works but it may surprise users because 'rue' in ('true'), 'u' in ('true'), etc. will also evaluate to True.