search

takikawa / tr-pfds

Typed Racket data structure libraries
58 stars 13 forks source link

Restore collection consistency #2

Closed mikesperber closed 11 years ago

mikesperber commented 11 years ago

These two changes

I'd be grateful if they could be merged.

takikawa commented 11 years ago

Thanks for the pull request! One thing I'd like to change before merging this is to move info.rkt back up to the root folder. The reason is that raco pkg relies on the file being there, and also because it causes a conflict with the info.rkt that exists already in collects/data. Does that seem ok?

mikesperber commented 11 years ago

Asumu Takikawa notifications@github.com writes:

Thanks for the pull request! One thing I'd like to change before merging this is to move info.rkt back up to the root folder. The reason is that raco pkg relies on the file being there, and also because it causes a conflict with the info.rkt that exists already in collects/data. Do you see any problem with that?

I was wondering what your intention was with respect to the module naming, but all documentation and all tests refer to data/XXX rather than tr-pfds/XXX, so moving info.rkt back up would break all that. My suggestion would be to rename the data directory, either to tr-pfds or (my preference) pfds, and adjust the references accordingly.

Regards, Mike

takikawa commented 11 years ago

I was wondering what your intention was with respect to the module naming

It's using the data collection name because with Planet 2, it's possible to inject parts of packages into already existing collections. The trouble seems to be that if you use raco link (like I think you're doing), it doesn't quite work like raco pkg does. Maybe I will move to pfds instead so that it will work either way.