batchedStatements is not taken into account - Githubissues

takimafr / spring-dbunit

DBUnit support for Spring

Apache License 2.0

40 stars 19 forks source link

batchedStatements is not taken into account #21

Closed eric-taix closed 11 years ago

eric-taix commented 11 years ago

Even if I set batchedStatements=true, it is not taken into account and a SimplePrepareStatement is created instead of a PreparedBatchStatement !

In the TestConfigurationProcessor#buildConfiguration method, you missed some withXXXX methods !

withBatchedStatements(annotation.batchedStatements())
withBatchSize(annotation.batchSize())

and perhaps more ;-)

slandelle commented 11 years ago

Are you sure this hasn't already been fixed? https://github.com/excilys/spring-dbunit/blob/master/spring-dbunit-test/src/main/java/com/excilys/ebi/spring/dbunit/test/TestConfigurationProcessor.java#L109

Which version do you use?

eric-taix commented 11 years ago

You're right, I used version 1.1.8 but I was sure to be uptodate => Eclipse maven plugin didn't show me version 1.1.12 :-(

I'll have a look to my nexus conf. Thanks for the good job and sorry.

slandelle commented 11 years ago

No pro :)

Note that I had to remove tons of old versions of our projects from our Nexus in order to facilitate a migration, so you'll only have 1.1.12 in there.