search

takimafr / spring-dbunit

DBUnit support for Spring
Apache License 2.0
40 stars 19 forks source link

Spring4 #31

Closed davidkarlsen closed 10 years ago

davidkarlsen commented 10 years ago

This fixes https://github.com/excilys/spring-dbunit/issues/27 with the upgrade to the spring 4.0.0.Final version available as of today.

Could you pull this and make a release? Maybe you want to bump the x or y version in x.y.z due to this?

slandelle commented 10 years ago

Hi,

Actually, judging from your commits, it looks like supporting Spring 4 is just a matter of changing the dependency and there's no impact on the code.

If you want to use spring-dbunit w/ Spring 4, why don't you simply use something like maven's dependencyManagement? At this point, I don't see a reason force enforcing Spring 4 that's just been released to all users.

Cheers,

Stéphane

davidkarlsen commented 10 years ago

If you look at the issue-descriptions in https://github.com/excilys/spring-dbunit/issues/27 and https://jira.springsource.org/browse/SPR-7692 you will see that TestContext is no longer a class but an interface in Spring 4, and thus you will get a IncompatibleClassChangeError if you simply set spring 4 in the dependency section. By not compiling towards spring 4 you are leaving users with no option to upgrade spring and use spring-dbunit at the same time...

slandelle commented 10 years ago

OK, so let's bump version then.

davidkarlsen commented 10 years ago

Great! Will you push a release as well?

slandelle commented 10 years ago

Done!