Closed ozmium closed 4 years ago
The material design guidelines' Android settings part shows the dividers as full-length ones, so I'd stick to that instead of some old implementation.
Regarding the locale problem, I think it's related to appcompat so there's not much to do about it in this lib.
Ah I see. So I asssume the divider line style is intentional, and not a bug.
I will close this issue. Thanks for explaining.
On the native Android Preference --
android.preference.Preference
-- the preference rows use a divider that has some padding added to the left and right, so that the lines do not go all the way to the edge of the screen.Also, the native Android Preference has a larger default left and right padding for every list row.
But both the takisoft Preference and the AndroidX library Preference --
androidx.preference.preference
do not have the same divider line style and default padding.Screenshot examples:
Native Android Preference --
android.preference.PreferenceFragment
AndroidX Library Preference --
androidx.preference.PreferenceFragmentCompat
andcom.takisoft.preferencex.PreferenceFragmentCompat
There is a workaround for the general padding of the rows, taken from here:
But I'm not sure if this is the right approach, because different screen sizes (for example phones and tablets, portrait and landscape) probably had different amounts of padding.
I cannot find a workaround for the divider lines.
So is there a way to make the AndroidX library and takisfot library adopt the same padding styles as the original native preference?
Another perhaps unrelated issue:
These two libraries cause problems with internal Locale/language switching in Android apps, on API 21 (Android 5.0) to 25 (Android 7.1).
The problem is discussed here: https://stackoverflow.com/questions/55265834/change-locale-not-work-after-migrate-to-androidx
But is there a way you can fix it internally inside the library?