search

takluyver / jupyter_kernel_mgmt

Experimental new kernel management framework for Jupyter
https://jupyter-kernel-mgmt.readthedocs.io/en/latest/
Other
15 stars 8 forks source link

Let KernelManager hold kernel_id #14

Closed kevin-bates closed 5 years ago

kevin-bates commented 5 years ago

Kernel providers will want to use the same kernel_id used by the MappingKernelManager as a means of managing a kernel's lifecycle. This PR adds a kernel_id member to the KernelManager abstract base class and initializes its value in the KernelManager constructor. This allows kernel providers to determine the best location for where to set kernel_id so that it can be used to manage the kerne's lifecycle.

The MappingKernelManager start logic will then derive the kernel_id from the provider's KernelManager instance.

Fixes #10

codecov-io commented 5 years ago

Codecov Report

Merging #14 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   68.47%   68.51%   +0.04%     
==========================================
  Files          27       27              
  Lines        1922     1925       +3     
==========================================
+ Hits         1316     1319       +3     
  Misses        606      606
Impacted Files Coverage Δ
jupyter_kernel_mgmt/subproc/manager.py 57.35% <100%> (+1.29%) :arrow_up:
jupyter_kernel_mgmt/managerabc.py 60% <100%> (+1.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a74331...717d522. Read the comment docs.