search

takluyver / nbopen

Open a Jupyter notebook in the best available server
BSD 3-Clause "New" or "Revised" License
304 stars 58 forks source link

TypeError in find_best_server #1

Closed fonnesbeck closed 10 years ago

fonnesbeck commented 10 years ago

Using nbopen on some of my notebooks fails with the following (OSX 10.9.4, Homebrew Python 2.7.6):

-> % nbopen 2_Scientific-Computing-with-Python.ipynb 
Traceback (most recent call last):
  File "/usr/local/bin/nbopen", line 3, in <module>
    main()
  File "/usr/local/lib/python2.7/site-packages/nbopen.py", line 46, in main
    nbopen(args.filename, args.profile)
  File "/usr/local/lib/python2.7/site-packages/nbopen.py", line 23, in nbopen
    server_inf = find_best_server(filename, profile)
  File "/usr/local/lib/python2.7/site-packages/nbopen.py", line 16, in find_best_server
    default=None)
TypeError: max() got an unexpected keyword argument
takluyver commented 10 years ago

Oh, it looks like that parameter's new in Python 3.4.

takluyver commented 10 years ago

This was fixed by 9e13c41dfc57a482637798506eac4159e02650f1