takluyver / nbopen

Open a Jupyter notebook in the best available server
BSD 3-Clause "New" or "Revised" License
304 stars 58 forks source link

nbopen -p uses only default profile. #10

Open mforbes opened 9 years ago

mforbes commented 9 years ago

When running nbopen -p my_profile Notebook.ipynb, a new notebook server is started using profile_default rather than profile_my_profile. This is probably because line 37 for nbopen.py does not pass the --profile flag:

                                        argv=[],  # Avoid it seeing our own argv

Instead, it should probably be something like

                                        argv=['--profile', profile],  # Avoid it seeing our own argv

It appears that nbopen is careful to only share existing servers if they are running the same profile, so this is only an issue when starting a new nbserver.

takluyver commented 9 years ago

This is true, but as we're moving the notebook to the name Jupyter, we're planning to drop the notion of explicit profiles for the notebook server - you'll still be able to use multiple config directories with an environment variable like JUPYTER_DIR. So I don't want to add more support for profiles in nbopen now.