search

takluyver / nbopen

Open a Jupyter notebook in the best available server
BSD 3-Clause "New" or "Revised" License
304 stars 58 forks source link

enable query parameter passing #35

Open marqh opened 8 years ago

marqh commented 8 years ago

Hi @takluyver

Great tool, many thanks.

I have a proposed adaption, which enable query parameters to be passed to the notebook to be opened.

This enables a number of use cases to be addressed, including 

https://localhost:8888/notebooks/explore.ipynb?dashboard

opening the notebook in dashboard view

I hope this seems like a useful feature. Is the implementation up to scratch?

cheers mark

marqh commented 8 years ago

Hi @takluyver

I have altered the approach, such that the process to open a new notebook can be held in a thread whilst a new server is created, if required

this has the advantage that the logic for opening a notebook is encapsulated, rather than being different for a new server or an already open one

however, there are aspects that I think could be neater, for example, there is an arbitrary time to wait, which seems a bit inelegant

if you like the approach in principle, I can look to tidy up the implementation; any suggestions on this are most welcome However, if the approach raises significant concerns for you, let me know and i'll not pursue it further

thank you mark