search

takluyver / pynsist

Build Windows installers for Python applications
https://pynsist.readthedocs.io/
Other
896 stars 119 forks source link

Can't extract wheels in 2.7 #116

Closed gricey432 closed 7 years ago

gricey432 commented 7 years ago

Commit 7c70637 uses exist_ok which isn't backward compatible to 2.7

Siecje commented 7 years ago

I guess the backport of pathlib doesn't have that parameter?

https://docs.python.org/3/library/pathlib.html#pathlib.Path.mkdir

https://pypi.python.org/pypi/pathlib/

Edit: Yup, looks like it https://bitbucket.org/pitrou/pathlib/src/11f10035e7fb51622e65c71ffdbd6d241e31de74/pathlib.py?at=pep428&fileviewer=file-view-default#pathlib.py-1101

takluyver commented 7 years ago

We should probably switch to pathlib2 for the backport; hopefully that does have the parameter.

gricey432 commented 7 years ago

It looks like pathlib2 does have it https://github.com/mcmtroffaes/pathlib2/blob/develop/pathlib2.py#L1430

takluyver commented 7 years ago

Great :-) Anyone want to do a PR?

gricey432 commented 7 years ago

I was writing one but I couldn't see how to run it locally cause there's no setup.py so I figured I'd have another look later

takluyver commented 7 years ago

That commit should do it. The packaging uses flit, which does make it a bit awkward on Python 2, but I'm planning to make Pynsist require Python 3 soon anyway (#99).

takluyver commented 7 years ago

I've stuck a new release (1.12) up with this fixed.