search

takluyver / pynsist

Build Windows installers for Python applications
https://pynsist.readthedocs.io/
Other
882 stars 119 forks source link

Install location change from 1.x to 2.x #139

Closed beardypig closed 6 years ago

beardypig commented 6 years ago

It seems that the installation location has changed in 2.0, applications are installed to Users\%USER%\AppData\Local\ instead of Program Files. Is it possible to change this behaviour in 2.0?

takluyver commented 6 years ago

If the user has admin rights, they should see a choice between installing for all users and just for themselves. If they choose to install for all users, it should go in program files just like before. If they install only for their own user, it goes in the user folder.

This uses the MultiUser.nsh script.

beardypig commented 6 years ago

Thanks, you're right. Totally our bad, we are overriding the ui_pages block and didn't include !insertmacro MULTIUSER_PAGE_INSTALLMODE. :)

takluyver commented 6 years ago

Not entirely your bad - maybe I could have thought more carefully about people using custom templates, but it's tricky to evolve Pynsist itself without breaking that interface.

beardypig commented 6 years ago

Well it might be useful to be able to change some of the MULTIUSER variables, like being able to !undef MULTIUSER_INSTALLMODE_DEFAULT_CURRENTUSER before MultiUser.nsh is loaded.

takluyver commented 6 years ago

Do you want to make a PR introducing a new block?

beardypig commented 6 years ago

Something like this 4f2996196dae7594fe286530a7270a0d4f0d57f6 ?

takluyver commented 6 years ago

Yup, exactly. I'd call it something like multiuser_defs