Create a local_wheels parameter to include wheel files matching one or more glob paths

takluyver / pynsist

Build Windows installers for Python applications

https://pynsist.readthedocs.io/

Other

896 stars 119 forks source link

Create a local_wheels parameter to include wheel files matching one or more glob paths #164

Closed adferrand closed 6 years ago

adferrand commented 6 years ago

Following #163 where we specified a mechanism to include local wheel files matching a path pattern.

Here is the PR to include all wheel files matching a list of glob paths specified in the local_wheels parameter, located under the [Include] section.

Matching wheel files will be processed into the installer the same way than wheels found from wheels_pypi.

Furthermore, any of the following situation will raise an error:

two wheels to be included for the same distribution name
a wheel to be included not compatible with the python version in the installer, or not compatible with Windows platforms.

adferrand commented 6 years ago

All settled !

takluyver commented 6 years ago

@adferrand I'm a bit confused by your latest comments. I'm currently assuming you have made some further changes and I'm waiting for you to push them. Just letting you know in case you're waiting for me. :slightly_smiling_face:

adferrand commented 6 years ago

Yes sorry I wrote the comments and I was stopped before pushing the commit. You will get them soon.

takluyver commented 6 years ago

No problem, I just wanted to make sure we weren't deadlocked.

takluyver commented 6 years ago

Thank-you :+1:

takluyver commented 6 years ago

@adferrand I released Pynsist 2.2 earlier today, including this and the other changes you've contributed. Thanks for your contributions. :-)

adferrand commented 6 years ago

You are welcome ^^

And thanks for your project that, I think, offers the most elegant way to package pythons apps for Windozs.