search

takluyver / pynsist

Build Windows installers for Python applications
https://pynsist.readthedocs.io/
Other
896 stars 119 forks source link

add site.addsitedir to nsist __init__.py SCRIPT_TEMPLATE? #174

Closed DGalt closed 5 years ago

DGalt commented 5 years ago

I came across #137 as I struggled today to get pywin32 working in an application I'm trying to distribute with pynsist. I couldn't figure out why despite the fix applied in #138 I was still running in to issues.

Looking at the resulting .pyw file that pynsist creates I realized that the call to site.addsitedir that was added to commands.py in #138 was not there. Digging more in to how the the .pyw file is created it seems like that extra step of using site is not in the SCRIPT_TEMPLATE in __init__.py

I patched my local version to so that the SCRIPT_TEMPLATE string in __init__.py matches the one in commands.py and now everything is working properly.

Am I missing something in terms of setting up my configuration file, or should this have been included there as well when that change was made?

takluyver commented 5 years ago

I think it was just an oversight, and it should be added to the script template for GUI launchers as well. Do you want to make a PR?

takluyver commented 5 years ago

Closed by #175.

SecT0uch commented 5 years ago

Hey @takluyver, do you plan to release the 2.4 soon ? I really need this fix. I know I could edit by hand, but I would prefer a proper installation from a release.

takluyver commented 5 years ago

There you go, 2.4 is out now.