Closed bastimeyer closed 5 years ago
Just built a couple of installers and noticed a quotation mistake in NSIS' _assemble_launchers call. That's fixed now.
@takluyver Is there a chance for a review this week? I would really love to get this issue out of the way as soon as possible. Thanks!
Sorry for the delay; as I hinted, this isn't part of my day job, and I don't always feel like more work with code after spending the day doing that. Taking a look now.
Any further changes, or is this good to go? :)
Thanks! :smiley:
As described in #169
Adds an optional
console
property to the command sections with default valuetrue
. If set tofalse
, the command's launcher will be built from one of the GUI launchers ofsimple_launcher
and a shebang withpythonw.exe
will be included instead ofpython.exe
.Changes:
console
command propertylauncher_exe.dat
andlauncher_noconsole_exe.dat
)command-append.zip
andcommand-append-noconsole.zip
, depending on the command'sconsole
value_assemble_launchers.py
to reflect these changes and change its argvs so that the shebang can be testedI haven't actually built any installers with these changes yet, but the updated tests should assure that this is fine. There are also a couple of things which could be improved in the future, like importing file name constants for example.