takluyver / pynsist

Build Windows installers for Python applications
https://pynsist.readthedocs.io/
Other
896 stars 119 forks source link

Implement `console` command section property #179

Closed bastimeyer closed 5 years ago

bastimeyer commented 5 years ago

As described in #169

Adds an optional console property to the command sections with default value true. If set to false, the command's launcher will be built from one of the GUI launchers of simple_launcher and a shebang with pythonw.exe will be included instead of python.exe.

Changes:

I haven't actually built any installers with these changes yet, but the updated tests should assure that this is fine. There are also a couple of things which could be improved in the future, like importing file name constants for example.

bastimeyer commented 5 years ago

Just built a couple of installers and noticed a quotation mistake in NSIS' _assemble_launchers call. That's fixed now.

bastimeyer commented 5 years ago

@takluyver Is there a chance for a review this week? I would really love to get this issue out of the way as soon as possible. Thanks!

takluyver commented 5 years ago

Sorry for the delay; as I hinted, this isn't part of my day job, and I don't always feel like more work with code after spending the day doing that. Taking a look now.

bastimeyer commented 5 years ago

Any further changes, or is this good to go? :)

takluyver commented 5 years ago

Thanks! :smiley: