Edit wheels.py to include python 3.8 compatibility for ABI tags witho…

takluyver / pynsist

Build Windows installers for Python applications

https://pynsist.readthedocs.io/

Other

896 stars 119 forks source link

Edit wheels.py to include python 3.8 compatibility for ABI tags witho… #192

Closed christopherwallis closed 3 years ago

christopherwallis commented 4 years ago

The changes to ABI flags in python 3.8 make the ABI score/check function in wheels.py fail. Previous requirements were for "cp{version}m", "abi3" or "none".

"Default sys.abiflags became an empty string: the m flag for pymalloc became useless (builds with and without pymalloc are ABI compatible) and so has been removed. (Contributed by Victor Stinner in bpo-36707.)"
What's new in Python 3.8

The changes made add an extra allowable option if the python version is 3.8 or greater: "cp{version}"

takluyver commented 4 years ago

Thanks! I'm not super keen on the version comparison as an integer (I know 310 > 38, but 310 is also > 42, so it seems like the wrong pattern to establish).

christopherwallis commented 4 years ago

Yeah agreed, after posting I thought I should have got some broader test data. I'll have a think about it and implement some unit tests. thanks for the quick reply!

takluyver commented 3 years ago

I've merged #210 to fix the same thing. Thanks for contributing, even if this PR didn't get merged!