search

takluyver / pynsist

Build Windows installers for Python applications
https://pynsist.readthedocs.io/
Other
930 stars 123 forks source link

ABI tags in 3.8+ dropped the 'm' #203

Closed dmulkey-qubitekk closed 4 years ago

dmulkey-qubitekk commented 4 years ago

Hi there,

On line 40 of wheels.py (definition of score_abi under CompatibilityScorer), there's a comment of "Is the m reliable" referring to the 'm' in ABI tags of 'cp36m' or 'cp37m.' In packages with Python 3.8+, the m has been dropped. Examples include matplotlib, scipy, numpy, and Pillow.

The release notes for wheel confirm this. Here's the referenced PR. Looks like it stems from changes described under What's New In Python 3.8.

A (lame?) workaround is to redefine d as follows (haven't checked for passing tests):

d = {'cp%sm' % py_version_nodot: 3,  # Is the m reliable?  
    'cp%s' % py_version_nodot: 3,  
    'abi3': 2, 'none': 1}

Cheers, -Daniel

dmulkey-qubitekk commented 4 years ago

Shoot, I checked for preexisting issues, but I didn't notice that someone already submitted a PR addressing this. Sorry! Thanks for making a great package!