takluyver / pynsist

Build Windows installers for Python applications
https://pynsist.readthedocs.io/
Other
896 stars 119 forks source link

Docs: Example applications links broken #214

Closed fohrloop closed 3 years ago

fohrloop commented 3 years ago

In the documentation page, there are few broken links / removed examples

takluyver commented 3 years ago

Thanks, good catch. Those examples were removed when Pynsist 2.0 dropped support for Python 2.7 and running the Python.org installer (now we use the embeddable Python build instead).

Do you want to make a PR to remove them from the list?

We could leave a note underneath to mention that Pynsist 1.x also had examples for PyGTK and PyQt4. I'm in two minds - it's obviously helpful to mention that it's possible if people are using those frameworks, but I don't want to imply that it's still supported or receiving bugfixes.

fohrloop commented 3 years ago

Here you are! Fast fix. Maybe it's better that you or anyone more familiar with the framework and its history gives the possible notes for PyGTK / PyQt4.

takluyver commented 3 years ago

Thanks!