search

takluyver / weatbag

Written by Everyone Altogether, The Big Adventure Game
MIT License
21 stars 11 forks source link

Southern tiles 1 #10

Closed ghost closed 11 years ago

ghost commented 11 years ago

Building some adventures in the vicinity of S2, S3.

takluyver commented 11 years ago

Looks promising. What's the short man going to do?

ghost commented 11 years ago

I'm headed off on a vacation so I don't think I'll be putting in any work on this project for a week or so. Thanks for the tips!

takluyver commented 11 years ago

Have fun! I'll try to dissuade other people from doing s2 & s3 in the meantime.

takluyver commented 11 years ago

I hope you had a good holiday! No-one's claimed these tiles yet, so you're welcome to finish them off whenever you're back.

ghost commented 11 years ago

Alright, done with s3.

I hope to write several more tiles that have short magical guys up to no good. I will tie them together somehow. Should I use this pull request for any future tiles I add, or should this be closed and others opened?

takluyver commented 11 years ago

You've added a .swp file - can you get rid of that? Also, you use a short_man_gone variable which I don't think you define.

I'm on my phone just now, so I'll have a closer look when I'm on my computer. Thanks!

takluyver commented 11 years ago

This is looking pretty good, I've just spotted a few more things now I've got it on a larger screen.

If you can fix this up, I'll merge this, and then you can make new pull requests to add other groups of tiles.

takluyver commented 11 years ago

Great, that's looking good, and I'm going to merge it now. Thanks!

(Github tip: I get notified when you comment, but not when you push changes, so if you add a commit to a pull request, leave a comment so that I get an email)