search

takluyver / weatbag

Written by Everyone Altogether, The Big Adventure Game
MIT License
21 stars 11 forks source link

Added s1w1 #14

Closed dknox2 closed 6 years ago

dknox2 commented 11 years ago

I've added the s1w1 tile, featuring a quick conversation with a stranded merchant on a beach. I have plans to allow him to trade with the player, and give the player quests. Perhaps, it may be possible for the player to sail with the merchant, if his ship is fixed.

I'm also fairly new to GitHub, as well as programming. So if I'm doing something wrong, feel free to let me know.

takluyver commented 11 years ago

This looks like a great start! How is the merchant going to know that you've killed the orc? Will you have to bring him something as proof?

dknox2 commented 11 years ago

I figured I could use the weatbag.tiles.n3.enemy_dead variable, but upon test, it skipped it and went straight to the dialog I set for it, so I just cut it out.

takluyver commented 11 years ago

That's a bit tricky, because the enemy_dead variable is attached to the instance, and we don't currently give you any way to inspect other tiles.

dknox2 commented 11 years ago

Then I guess the orc could drop an item, which could then be used as proof. It's probably much simpler that way anyways.

takluyver commented 11 years ago

Yep, I was thinking of making it drop something. You could even bring back its head!

By the way, a small tip: try to make commit messages describe what you've changed, rather than just which file it's in. It's not always easy to think of a good summary, but it's good practice, and it makes the commit log more useful.

dknox2 commented 11 years ago

Ah, thanks!

takluyver commented 11 years ago

Hi Charles, have you had a chance to update this?

dknox2 commented 11 years ago

Sorry, I've been away for a LONG TIME. I'm working on it right now!

takluyver commented 11 years ago

Cool, I look forward to seeing it.