search

taktoa / eqsat

A language-generic implementation of equality saturation in Haskell
Other
21 stars 3 forks source link

Remove unused package dependencies which aren't buildable with ghc-8.2 #7

Closed lemmih closed 6 years ago

lemmih commented 6 years ago

The EqSat.Internal.Compact module doesn't build with ghc-8.2 but that module isn't used. Quite a few unused dependencies also doesn't build with newer versions of GHC.

taktoa commented 6 years ago

I'm still on GHC 8.0.2, unfortunately. I'll probably move to 8.2.x or 8.4.x after graduation when I have more free time (soon! :-)). EqSat.Internal.Compact is meant to be able to compile with any version of GHC >= 8.0, so I'd prefer to just fix the bug (it uses CPP to expose the same interface under 8.0 and 8.2, with the intention of acting as a stub for the compact library). If you want to build this in the mean time, please use the pinned nix stuff.

lemmih commented 6 years ago

Is this better?

I'm not sure how you manage to build against sbv-7.5 or sbv-7.6. Looks to me like you definitely need version sbv-7.7.

taktoa commented 6 years ago

Right now I'm using a patched version of sbv that exposes all the unexposed modules, so it's irrelevant for now. I just didn't want to have to file a PR every time I noticed that sbv failed to expose something (and when this goes on Hackage, I'll file that PR).

lemmih commented 6 years ago

If you fork the sbv repo and apply the patch then eqsat will also be buildable by stack.

taktoa commented 6 years ago

As of 6824ec159db957d91d76e1106916897608bead51 this should be fixed. If you file an issue I'll get around to fixing the build for stack soon (I might forget otherwise) Thanks for the contribution! (5523b4e7fdf28aeefea8db393403944e698bb685 includes these changes)

taktoa commented 6 years ago

This repo now builds under GHC 8.4.3