search

takuron1996 / MobileNovelReader

お試し
0 stars 0 forks source link

フォロー機能（お気に入り）の実装 #12

Closed takuron1996 closed 8 months ago

takuron1996 commented 8 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 8 months ago

Walkthrough

この変更では、MobileNovelReader アプリのネットワークリクエストの取り扱いが大幅に更新されました。HTTPメソッドを定義する新しい列挙型が導入され、APIエンドポイントのリクエストを URL から URLRequest に変更しました。また、フォロー機能のUIとロジックが改善され、データの取得方法が統一されました。

Changes

ファイルパス 変更概要
MobileNovelReader/Common/Endpoint.swift
MobileNovelReader/Common/Fetcher.swift		 - HttpMethod 列挙型の追加
- ApiEndpoint に follow ケースの追加と request 計算プロパティの変更
- request が URLRequest を返すように変更
- Fetcher クラスの fetchData メソッドが URLRequest を受け入れるように変更
MobileNovelReader/Config/EnvironmentVariables.swift - Config 構造体の追加
- Info.plist から api_url を読み込むグローバルインスタンス config の導入
MobileNovelReader/ContentsDisplay/ContentsChapterView.swift
MobileNovelReader/ContentsDisplay/ContentsDetailView.swift
MobileNovelReader/ContentsDisplay/ContentsFooterView.swift
MobileNovelReader/ContentsDisplay/ContentsSubTitleView.swift
MobileNovelReader/ContentsDisplay/ContentsSummaryView.swift
MobileNovelReader/ContentsDisplay/ContentsTagView.swift
MobileNovelReader/ContentsDisplay/ContentsView.swift		 - コメントの追加とUIの改善
- プロパティやメソッドの追加や変更
MobileNovelReader/ContentsDisplay/FollowData.swift
MobileNovelReader/ContentsDisplay/NovelInfoData.swift		 - FollowData と FollowBody 構造体の導入
- NovelInfo 構造体の追加
MobileNovelReader/NovelDisplay/MainTextData.swift
MobileNovelReader/NovelDisplay/NovelDisplayMenuView.swift
MobileNovelReader/NovelDisplay/NovelDisplayView.swift		 - 新しい構造体や機能の追加
- コメントの追加とロジックの更新

🐇🌟
新しい道を切り開いた、
コードの森を駆ける兎。
データの流れを変え、
読み手の心を繋ぐ。
進化する物語、永遠に。
📚🚀🌙

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
furutahidehiko commented 8 months ago

LGTM