search

takuti / Recommendation.jl

Building recommender systems in Julia
https://takuti.github.io/Recommendation.jl/latest/
MIT License
48 stars 10 forks source link

Fix most popular count #19

Closed takuti closed 3 years ago

takuti commented 3 years ago

Fix #16

After 6031452283a5b466c7fff1246c138cfbdf73d935, missing values are filled out by undef.

MostPopular must not count any zeros and undefs, which equal very small numbers.

codecov-io commented 3 years ago

Codecov Report

Merging #19 (59f2d5c) into master (f306b6a) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   96.85%   96.93%   +0.07%     
==========================================
  Files          19       19              
  Lines         350      359       +9     
==========================================
+ Hits          339      348       +9     
  Misses         11       11
Impacted Files Coverage Δ
src/baseline/co_occurrence.jl 100.00% <100.00%> (ø)
src/baseline/most_popular.jl 100.00% <100.00%> (ø)
src/baseline/threshold_percentage.jl 100.00% <100.00%> (ø)
src/data_accessor.jl 100.00% <100.00%> (ø)
src/evaluation/cross_validation.jl 100.00% <100.00%> (ø)
src/model/item_knn.jl 97.05% <100.00%> (ø)
src/model/user_knn.jl 97.50% <100.00%> (+0.06%) :arrow_up:
src/utils.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f306b6a...59f2d5c. Read the comment docs.