search

takuyaa / kuromoji.js

JavaScript implementation of Japanese morphological analyzer
832 stars 117 forks source link

Change dict path #21

Closed zuhito closed 6 years ago

zuhito commented 6 years ago

I think the default directory path is invalid. If it's true, please accept my pull request.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 93.75% when pulling b0f0cb7abc9724c09f26d4af5e78f160f812bfbe on zuhito:master into 8f30e7e4adb0df739668372d828328dc48f9b1a2 on takuyaa:master.

codecov-io commented 6 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files          22       22           
  Lines         923      923           
  Branches      106      106           
=======================================
  Hits          866      866           
  Misses         57       57
Impacted Files Coverage Δ
src/TokenizerBuilder.js 90.9% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f30e7e...b0f0cb7. Read the comment docs.

takuyaa commented 6 years ago

@zuhito Why do you think so? This or this works now. If you know such case that works under the condition option.dicPath == "../dict", notify me it again please. Thanks.