search

takuyaa / kuromoji.js

JavaScript implementation of Japanese morphological analyzer
848 stars 118 forks source link

Fix test dependencies #24

Closed ikawaha closed 6 years ago

ikawaha commented 6 years ago

Use node v8.x.x, npm run test failed with following messages:

> kuromoji@0.1.1 test /Users/ikawaha/go/src/github.com/takuyaa/kuromoji.js
> gulp test

/Users/ikawaha/go/src/github.com/takuyaa/kuromoji.js/node_modules/require-dir/index.js:93
            if (!require.extensions.hasOwnProperty(ext)) {
                                    ^

TypeError: require.extensions.hasOwnProperty is not a function
coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 93.75% when pulling a3896463ce848c6f53189832cf11b2b87e71e4ee on ikawaha:fix/test_dependencies into 8f30e7e4adb0df739668372d828328dc48f9b1a2 on takuyaa:master.

codecov-io commented 6 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files          22       22           
  Lines         923      923           
  Branches      106      106           
=======================================
  Hits          866      866           
  Misses         57       57

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f30e7e...a389646. Read the comment docs.

takuyaa commented 6 years ago

@ikawaha Thanks a lot! LGTM 👍