search

takuyaa / kuromoji.js

JavaScript implementation of Japanese morphological analyzer
832 stars 117 forks source link

Fix decoding bug of short int #25

Closed ikawaha closed 6 years ago

ikawaha commented 6 years ago

This bug caused excessive evaluation of negative word_cost. (e.g. 研究=-413 is overvalued 65123.) See https://github.com/takuyaa/kuromoji.js/issues/23

codecov-io commented 6 years ago

Codecov Report

Merging #25 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   93.82%   93.84%   +0.02%     
==========================================
  Files          22       22              
  Lines         923      926       +3     
  Branches      106      107       +1     
==========================================
+ Hits          866      869       +3     
  Misses         57       57
Impacted Files Coverage Δ
src/util/ByteBuffer.js 94.7% <100%> (+0.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f30e7e...4f5649c. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 93.77% when pulling 4f5649c65496c4a4420c62e77c7009d85bfed9f1 on ikawaha:fix/decode_short into 8f30e7e4adb0df739668372d828328dc48f9b1a2 on takuyaa:master.