search

takuyaa / kuromoji.js

JavaScript implementation of Japanese morphological analyzer
832 stars 117 forks source link

[WIP] Migrate to TypeScript #29

Open takuyaa opened 5 years ago

chigix commented 4 years ago

Waiting for this release

ghost commented 4 years ago

When will this be merged and released?

takuyaa commented 4 years ago

@chigix @subs1da I would like to know why you want this. This is not a kind of function, so there is no user's merit. Could you explain your situation or needs?

chigix commented 4 years ago

@takuyaa TypeScript implementation is attractive. If there could be typescript base code, morphological analyzing could become available for both nodejs and browser usage and building, though it might be still not be covered in the goal of current development.

In addition, I'm using Angular, which is a pioneer project employing TypeScript among the most famous modern frontend solution frameworks. Because there is no sophisticated JavaScript implementation especially for the usage within TypeScript, I have to do Japanese texts parsing and analysis with Server API implementation -- now I'm using the Kuromoji implementation integrated in Elasticsearch, which is actually not good on the view of the cohesion inside one feature development and integration.

martinheidegger commented 3 years ago

@takuyaa I can not speak for others but I would like to send a new pull request and would like to contribute based on this typescript source code rather than trying to send a javascript pull request that needs to be heavily rebased at another time.

justinsilvestre commented 3 years ago

This is not a kind of function, so there is no user's merit.

The users benefit from using software that is free of bugs and regularly updated.

In some ways, static typechecking with TypeScript is just like having unit tests. It catches bugs (like null exceptions, "undefined is not a function" errors etc.) and lets developers refactor and write new features faster.