Closed xl1 closed 9 years ago
Thank you for your contribution to kuromoji.js! It seems to be very nice PR for me, but have some problems.
Names of normal variable (not class) are not camelCase
but snake_case
as you see in kuromoji.js repo.
For consistency, could you change variable names?
(ex. nodeZlib
to node_zlib
and typedArray
to typed_array
)
In addition, you don't need to update files under dist/
and jsdoc/
directory.
I think these files should be updated when we tag a version (and release it).
If you could modify (or revert) the 2 above, I am ready to merge this PR.
Thank you for replying! I've fixed them.
I appreciate your quick fix!
https://nodejs.org/api/zlib.html
This will improve performance to decompress dictionaries on Node.js environment.
I measured loader performance by a script below:
And the results (Windows 10, Node v0.12.6):