improve error handling of DictionaryLoader

takuyaa / kuromoji.js

JavaScript implementation of Japanese morphological analyzer

832 stars 117 forks source link

improve error handling of DictionaryLoader #7

Closed azu closed 8 years ago

azu commented 8 years ago

This will improve error handling of DictionaryLoader.

Before:

DictionaryLoader try to load non-exist dictionaries and wait for ∞.

After:

DictionaryLoader try to load non-exist dictionaries and call callback with Error.
Use path.join for joining dic_dir and filename.
- https://nodejs.org/api/path.html#path_path_join_path1_path2

azu commented 8 years ago

ping @takuyaa

takuyaa commented 8 years ago

I have just looked at your code and run on some browsers (Chrome or Safari). It seems to be correct and nice PR improving maintainability including also some refactoring, so merged right now. thanks.