Update README.md - Githubissues

talaia-labs / rust-teos

The Eye of Satoshi - Lightning Watchtower

https://talaia-labs.github.io/talaia.watch/

MIT License

134 stars 63 forks source link

Update README.md #111

Closed carboncls closed 2 years ago

sr-gi commented 2 years ago

@carboncls Thanks for giving this a look. Please add a minimal description to the PR.

carboncls commented 2 years ago

ok, I'm sorry, I'm very new to github and I'm not sure I know what to do here ... if you want, you can just correct this minor typo in the README without this PR.

mariocynicys commented 2 years ago

@carboncls You can:

Clone your fork, do the changes in the PR branch, push them to github (or force push them to keep the commit history clean), and they will automatically appear in this PR.
Go to your fork on github, do the changes in the PR branch from github's editor and commit them, and they will automatically appear in this PR. This way a maintainer will have to squash the PR into one commit when merging it.

sr-gi commented 2 years ago

@carboncls no worries, try to make the changes and, if you don't manage, I'll edit the description and squash the commits myself.

sr-gi commented 2 years ago

@carboncls can you patch the comments and rebase? I can do it myself otherwise.

carboncls commented 1 year ago

yes, I was busy with other stuff and didn't really know what to do. sorry for the confusion and thank you for the change.

sr-gi commented 1 year ago

No problem. Thank you for catching the typos.