talaia-labs / rust-teos

The Eye of Satoshi - Lightning Watchtower
https://talaia.watch
MIT License
128 stars 62 forks source link

`gettowerinfo` returns wrong port for `torv3` addresses #186

Closed mariocynicys closed 1 year ago

mariocynicys commented 1 year ago

In my local config, Tor runs on port 9513:

onion_hidden_service_port = 9513

But when running teos-cli gettowerinfo, it returns: image

Note that the tower's http interface run on port 9512 in my config.

mariocynicys commented 1 year ago

Here is where we record Tor's address information after starting the interface. https://github.com/talaia-labs/rust-teos/blob/4ce986e0bef0fb90aa6d9b7a74656422a68f4f1d/teos/src/main.rs#L294-L297

1010adigupta commented 1 year ago

Hey I am participating in Summer of Bitcoin, proposal round is yet to be started, for now I want to take up this issue.

sr-gi commented 1 year ago

Hey @1010adigupta, great to have you around.

Feel free to try to fix this and ping us if you have any questions. I've been out for a few days but should be back on Monday.

1010adigupta commented 1 year ago

yeah great, sure sure, you can assign me this issue.

sr-gi commented 1 year ago

Hey @1010adigupta, this is the last blocking bit for v0.2.0 release (no pressure 😂), do you think you'll manage to fix it in the next day or two?

Otherwise, we can assign you any other Good first issue and fix this one ourselves so the code can be released.

1010adigupta commented 1 year ago

Hey you can assign me another good first issue, it would be better not to delay the release.