talaia-labs / rust-teos

The Eye of Satoshi - Lightning Watchtower
https://talaia.watch
MIT License
128 stars 62 forks source link

Makes http::serve take a SockAddr instead of a starting #196

Closed sr-gi closed 1 year ago

sr-gi commented 1 year ago

This is a pretty simple PR, but it was hurting my eyes seeing that much replication and weird variable naming with respect to the internal API.

In a nutshell, this simply makes http::serve take grpc_bind as SocketAddr instead of String, so we can get rid of a useless variable and rename things more accordingly.

sr-gi commented 1 year ago

Actually, we only needed to enclose once (i.e. we don't need to clone twice, the second, and last, time can be a move).

sr-gi commented 1 year ago

@mariocynicys can you re-ack if this makes sense?

sr-gi commented 1 year ago

Removed the latest commit