Closed anmode closed 1 year ago
Sorry but I don't think this PR makes sense, nor it is achieving what it is claiming to.
- Removed the
fail-fast
option from the build job's strategy: This is unnecessary since the default value isfalse
, which is what we want.
This is not true. fail-fast
defaults to true
:
- Combined the two toolchain options into one in the build job's matrix definition: This simplifies the definition and makes it easier to read.
Not sure what you're trying to achieve here, but with your approach all seems to be built using ubuntu-latest
, which is certainly not what we're looking for.
- Added a exclude option to exclude the watchtower-plugin when building on Windows: The
watchtower-plugin
is not supported on Windows, so we need to exclude it from the build process on that platform.
This is exactly what was being done, but using a different syntax
- Upgraded to
actions/checkout@v2
: This is the latest version of the checkout action, and it's recommended to use it over previous versions.
How is v2 later than v3?
- Renamed the
Install Rust ${{ matrix.toolchain }} toolchain
steps to Setup Rust toolchain: This is a more accurate description of what the step is doing.
I don't think this is more accurate
Added a components option to the Setup Rust toolchain step in the lint job: This installs the
rustfmt
andclippy
components, which are used in the linting process.
This was already being done
- Changed the
cargo fmt
command in the lint job to use the--check option
: This checks the formatting of the code without actually changing it, which is more appropriate for a CI job.
This was also already there, it was not introduced by this PR
5.Added a
--deny
warnings option to thecargo clippy
command in the lint job: This causes clippy to treat warnings as errors, which ensures that the code is free of potential issues.
Same as before, clippy was already denying warnings (using the exact option you're mentioning)
Oh okayyy @sr-gi got that.... Thanks and sorry If I misunderstood something.
Here are the changes I made and why:
fail-fast
option from the build job's strategy: This is unnecessary since the default value isfalse
, which is what we want.watchtower-plugin
is not supported on Windows, so we need to exclude it from the build process on that platform.actions/checkout@v2
: This is the latest version of the checkout action, and it's recommended to use it over previous versions.Install Rust ${{ matrix.toolchain }} toolchain
steps to Setup Rust toolchain: This is a more accurate description of what the step is doing. Added a components option to the Setup Rust toolchain step in the lint job: This installs therustfmt
andclippy
components, which are used in the linting process.cargo fmt
command in the lint job to use the--check option
: This checks the formatting of the code without actually changing it, which is more appropriate for a CI job. 5.Added a--deny
warnings option to thecargo clippy
command in the lint job: This causes clippy to treat warnings as errors, which ensures that the code is free of potential issues.