search

talaia-labs / rust-teos

The Eye of Satoshi - Lightning Watchtower
https://talaia-labs.github.io/talaia.watch/
MIT License
134 stars 63 forks source link

Adds some notes on commits and GitHub to CONTRIBUTING #211

Closed sr-gi closed 1 year ago

sr-gi commented 1 year ago

Some newcomers are struggling with our ways of doing things, so it may be best to document what we expect so there are less friction/back-and-forth conversations in reviews.

sr-gi commented 1 year ago

@mariocynicys would you mind adding anything you see fit?

mariocynicys commented 1 year ago

@mariocynicys would you mind adding anything you see fit?

Nothing in mind tbh. But I would say I think the last section added in this PR (Remotes) is somewhat off-topic. It's more of a general git info than a contribution guideline. People manage their remotes differently and there is already online resources on how to do the same.

sr-gi commented 1 year ago

@mariocynicys would you mind adding anything you see fit?

Nothing in mind tbh. But I would say I think the last section added in this PR (Remotes) is somewhat off-topic. It's more of a general git info than a contribution guideline. People manage their remotes differently and there is already online resources on how to do the same.

I kinda agree. People were struggling a bit with how to work with branches and such so I decided to add it. But it may not be a good fit tbh