search

talaia-labs / rust-teos

The Eye of Satoshi - Lightning Watchtower
https://talaia.watch
MIT License
128 stars 62 forks source link

retrier::tests::test_manage_retry_unreachable may randomly fail #226

Open sr-gi opened 11 months ago

sr-gi commented 11 months ago

I haven't seen retrier tests randomly failing much lately, but yesterday I got this one:

https://github.com/talaia-labs/rust-teos/actions/runs/5448919099/jobs/9979994482?pr=225

Tracking this to keep an eye on it.

mariocynicys commented 11 months ago

Another timing? failure but in retrier::tests::test_manage_retry_while_idle: https://github.com/talaia-labs/rust-teos/actions/runs/5659276199/job/15332471299?pr=233

sr-gi commented 11 months ago

Looks like it. I hate timing-based tests :/

orbitalturtle commented 2 months ago

Locally I've also been getting a test_manage_retry_while_idle failure, looks like at this line: https://github.com/talaia-labs/rust-teos/blob/997f77f69541d96d64e2e7958e5bd4a7049b6efd/watchtower-plugin/src/retrier.rs#L1243

Maybe it'd be worth doing a loop, trying the same call every second or so, either until it succeeds or times out (with a longer timeout than it currently has)