talaia-labs / rust-teos

The Eye of Satoshi - Lightning Watchtower
https://talaia.watch
MIT License
128 stars 62 forks source link

Replace UUID with locator #237

Open aruokhai opened 9 months ago

aruokhai commented 9 months ago

Objective Ensure locators are returned instead of uuid's under appointments section when user details are fetched through the cli using the getuser command.

Problem locator is an appropriate identifier for appointments in the Bolt13 specification draft, which is also being used in the getappointments cli command , but in the getuser cli command uuid is being used which can be confusing . The solution is ensure getuser cli command makes use of locator and not uuid.

Changes

Scope Of Change This is a non critical change, as it only affects the CLI.

closes #229

sr-gi commented 9 months ago

@aruokhai thanks for looking at this. This is going to make much more sense after merging #190, which gets rid of all in-memory data for the tower. Hence, a big refactor will be needed, but it would make the change way smaller. I'd suggest you wait until that is landed and take another look at it.

sr-gi commented 9 months ago

@aruokhai we just landed #190

aruokhai commented 9 months ago

would take a look at it again and start working on a new fix

aruokhai commented 6 months ago

added the necessary changes