I recently realized that teos-common::cryptography::get_random_keypair was potentially incorrect.
The bytes used to generate the SecretKey were created outside the testing loop, meaning that if they didn't yield a valid secret key for whatever reason, the function would loop forever. I don't think this can really be the case, but this patch is certainly more correct than the older approach.
I recently realized that
teos-common::cryptography::get_random_keypairwas potentially incorrect.The bytes used to generate the
SecretKeywere created outside the testing loop, meaning that if they didn't yield a valid secret key for whatever reason, the function would loop forever. I don't think this can really be the case, but this patch is certainly more correct than the older approach.