talaia-labs / rust-teos

The Eye of Satoshi - Lightning Watchtower
https://talaia-labs.github.io/talaia.watch/
MIT License
135 stars 63 forks source link

Unnecessary strcutopt macros #62

Closed mariocynicys closed 2 years ago

mariocynicys commented 2 years ago

We have some structopt(rename_all = "lowercase") procedural macros around the configuration structs (like in here).

These macros are useful in option structs (like the example above). They render the command line options in lowercase chars and remove underscores from them.

But this particular instance should not have that macro applied since it's not a command line option. Because of this macro, this error message shows <userid>: image Instead of <user_id> or <user-id>.

We prefer one of (<user_id> / <user-id>).