talaia-labs / rust-teos

The Eye of Satoshi - Lightning Watchtower
https://talaia-labs.github.io/talaia.watch/
MIT License
135 stars 63 forks source link

Makes Tor task panics more user friendly #99

Closed sr-gi closed 2 years ago

sr-gi commented 2 years ago

Given we cannot address #57 atm, lets at least make it so if the Tor thread fails it does so in a more user friendly way.

mariocynicys commented 2 years ago

Does std::process::exit stop other spawned tokio threads?

sr-gi commented 2 years ago

Does std::process::exit stop other spawned tokio threads?

I've manually tested and looks like it does. std::process::exit terminates the current process, so I would assume so.

sr-gi commented 2 years ago

Any tACK? @booklearner @meryacine

Cannot make unit tests for this so manual testing would be appreviated

booklearner commented 2 years ago

ah, TIL tACK = test ACK - sorry for the premature approval 😅

sr-gi commented 2 years ago

@booklearner np np, we're all learning here 😛