fix until does not update when state.property is changed , stays one state behind.

talalmajali / react-native-countdown-component

React Native CountDown

MIT License

264 stars 233 forks source link

fix until does not update when state.property is changed , stays one state behind. #109

Open pwliuab opened 2 years ago

pwliuab commented 2 years ago

fix until does not update when state.property is changed , stays one state behind.

adding !this.state.isStartedCountDown and this.props.until !== this.preState.until in componentDidUpdate to check intial update
one state behind that's because this.props.until == this.preProp.until is always true, intially.

rayyanekaputra commented 2 years ago

im new, how do you pull this as an import CountDown from 'react-native-countdown-component'; ? or do i need to reinstall the whole library but with your branch? how do i achieve that? thank youu

pwliuab commented 2 years ago

im new, how do you pull this as an import CountDown from 'react-native-countdown-component'; ? or do i need to reinstall the whole library but with your branch? how do i achieve that? thank youu

you can first import the original countdown. Then, you go to the node modules of the original version. Find out the 'react-native-countdown-component' Then, take a look to my pull request, see what is added, you can fix it by adding my changes manually.